public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] Re: #ifdef missing in linux/irq_cpustat.h
Date: Wed, 26 Dec 2001 22:19:20 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590698805716@msgid-missing> (raw)

>>>>> On Wed, 19 Dec 2001 18:57:46 +0100 (MET), Erich Focht <efocht@ess.nec.de> said:

  Erich> Hi David, as far as I understand the type irq_cpustat_t is
  Erich> not defined on IA64 therefore the line (in
  Erich> include/linux/irq_cpustat.h):

  Erich> extern irq_cpustat_t irq_stat[]; /* defined in asm/hardirq.h
  Erich> */

  Erich> should probably be inside an #ifndef CONFIG_IA64 block...

Technically, you're correct.  But I don't think the extra declaration
hurts anything.  It is a platform-independent file, so I'm reluctant
to add an #ifdef.  I am working on getting the per-CPU data changes
accepted into the main line tree, but the going is very slow (Linus is
focusing on the bio stuff).  Actually, if someone has a good idea of
implementing fast local access to per-CPU data on x86, I'm all ears,
as this would help getting the changes accepted into the main tree.  I
assume the Sequent/IBM folks have solved this problem for their x86
NUMA machines already?

	--david


                 reply	other threads:[~2001-12-26 22:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590698805716@msgid-missing \
    --to=davidm@hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox