From: David Mosberger <davidm@hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] small but important fix for clone2()
Date: Sat, 09 Feb 2002 18:45:46 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590698806030@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590698806024@msgid-missing>
Thursday's patch isn't sufficient. It breaks threaded ia32 apps. The
patch below should be complete, but more testing needs to be done. At
least the x86 version of OpenOffice works again.
--david
--- arch/ia64/kernel/entry.S~ Thu Jan 24 17:16:06 2002
+++ arch/ia64/kernel/entry.S Sat Feb 9 10:41:59 2002
@@ -115,7 +115,7 @@
mov loc1=r16 // save ar.pfs across do_fork
.body
mov out1=in1
- mov out3=0
+ mov out3\x16 // stacksize (compensates for 16-byte scratch area)
adds out2=IA64_SWITCH_STACK_SIZE+16,sp // out2 = ®s
mov out0=in0 // out0 = clone_flags
br.call.sptk.many rp=do_fork
--- arch/ia64/ia32/ia32_entry.S~ Mon Nov 19 20:04:55 2001
+++ arch/ia64/ia32/ia32_entry.S Sat Feb 9 10:41:41 2002
@@ -37,7 +37,7 @@
mov loc1=r16 // save ar.pfs across do_fork
.body
zxt4 out1=in1 // newsp
- mov out3=0 // stacksize
+ mov out3\x16 // stacksize (compensates for 16-byte scratch area)
adds out2=IA64_SWITCH_STACK_SIZE+16,sp // out2 = ®s
zxt4 out0=in0 // out0 = clone_flags
br.call.sptk.many rp=do_fork
--- arch/ia64/kernel/process.c~ Mon Feb 4 22:38:51 2002
+++ arch/ia64/kernel/process.c Wed Feb 6 21:05:25 2002
@@ -267,7 +267,7 @@
if (user_mode(child_ptregs)) {
if (user_stack_base) {
- child_ptregs->r12 = user_stack_base + user_stack_size;
+ child_ptregs->r12 = user_stack_base + user_stack_size - 16;
child_ptregs->ar_bspstore = user_stack_base;
child_ptregs->ar_rnat = 0;
child_ptregs->loadrs = 0;
prev parent reply other threads:[~2002-02-09 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-08 3:30 [Linux-ia64] small but important fix for clone2() David Mosberger
2002-02-09 18:45 ` David Mosberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590698806030@msgid-missing \
--to=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox