From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gross, Mark" Date: Thu, 06 Jun 2002 16:28:00 +0000 Subject: RE: [Linux-ia64] [RFC] Multithreaded core dump for 2.5.10-ia64 ke Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org Good idea, I'll put the BUG_ON in. I'll re-base to the updated 2.5.18 ia64 patches, that include perfmon_itanium.h, and add the BUG_ON logic later today. Thanks, --mgross (W) 503-712-8218 MS: JF1-05 2111 N.E. 25th Ave. Hillsboro, OR 97124 > -----Original Message----- > From: David Mosberger [mailto:davidm@napali.hpl.hp.com] > Sent: Thursday, June 06, 2002 9:14 AM > To: Gross, Mark > Cc: linux-ia64@linuxia64.org > Subject: Re: [Linux-ia64] [RFC] Multithreaded core dump for > 2.5.10-ia64 > kernel. > > > >>>>> On Wed, 5 Jun 2002 14:33:12 -0700, "Gross, Mark" > said: > > Mark> I'm new to the stack unwinding thing WRT ia64 and would love > Mark> to get some feed back on my tweaks to process.c that collect > Mark> the register state data for the thread processes in the > Mark> crashing thread group. > > It looks fine to me. One suggestion, however: it might be a good idea > to add a BUG_ON(task != current) statement to the dump_task_regs() and > dump_task_fpu() routines. This will stop folks from accidentally > trying to use unw_init_from_blocked_task() for the currently running > task. > > --david >