From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] radeon frame buffer bug?
Date: Wed, 10 Jul 2002 04:24:39 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590701905750@msgid-missing> (raw)
Normally I don't turn on the frame buffer code, but by coincidence, I
had it turned on today on an Itanium 2 box with a Radeon card. The
kernel crashed late in the boot when the frame buffer driver was
trying to blink the cursor (I think). I took a quick look at the code
and it seems to me that the Radeon driver is missing an ioremap().
The patch below isn't quite correct, as the second argument to
ioremap() needs to be the size of the buffer (not sure what it is); of
course, on ia64 the size doesn't really matter due to the identity
mapping that we're using.
Anybody who's more familiar with this code have any comments?
--david
--- drivers/video/radeonfb.c~ Tue Feb 26 11:38:30 2002
+++ drivers/video/radeonfb.c Tue Jul 9 19:06:15 2002
@@ -1692,7 +1692,7 @@
disp->dispsw_data = NULL;
- disp->screen_base = (char*)rinfo->fb_base;
+ disp->screen_base = ioremap(rinfo->fb_base, 0);
disp->type = FB_TYPE_PACKED_PIXELS;
disp->type_aux = 0;
disp->ypanstep = 1;
next reply other threads:[~2002-07-10 4:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-10 4:24 David Mosberger [this message]
2002-07-10 6:51 ` [Linux-ia64] radeon frame buffer bug? David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590701905750@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox