From: Andreas Schwab <schwab@suse.de>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] PATCH 2.4.19 ppp_generic.c
Date: Tue, 27 Aug 2002 19:24:21 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590701905987@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590701905985@msgid-missing>
Grant Grundler <grundler@cup.hp.com> writes:
|> ppp_generic.c won't build as a module.
|> Using "outl" as a label is a bad idea.
IMHO <asm/io.h> should be fixed:
--- linux/include/asm-ia64/io.h.~1~
+++ linux/include/asm-ia64/io.h
@@ -272,18 +272,18 @@ __outsl (unsigned long port, void *src,
#define __outw platform_outw
#define __outl platform_outl
-#define inb __inb
-#define inw __inw
-#define inl __inl
-#define insb __insb
-#define insw __insw
-#define insl __insl
-#define outb __outb
-#define outw __outw
-#define outl __outl
-#define outsb __outsb
-#define outsw __outsw
-#define outsl __outsl
+#define inb(a) __inb(a)
+#define inw(a) __inw(a)
+#define inl(a) __inl(a)
+#define insb(a,b,c) __insb(a,b,c)
+#define insw(a,b,c) __insw(a,b,c)
+#define insl(a,b,c) __insl(a,b,c)
+#define outb(a,b) __outb(a,b)
+#define outw(a,b) __outw(a,b)
+#define outl(a,b) __outl(a,b)
+#define outsb(a,b,c) __outsb(a,b,c)
+#define outsw(a,b,c) __outsw(a,b,c)
+#define outsl(a,b,c) __outsl(a,b,c)
/*
* The address passed to these functions are ioremap()ped already.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2002-08-27 19:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-27 18:00 [Linux-ia64] PATCH 2.4.19 ppp_generic.c Grant Grundler
2002-08-27 19:24 ` Andreas Schwab [this message]
2002-08-27 19:58 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590701905987@msgid-missing \
--to=schwab@suse.de \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox