public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] make xconfig
Date: Wed, 28 Aug 2002 19:11:30 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590701905997@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590701905993@msgid-missing>

On Wed, 28 Aug 2002 09:02:16 -0700 (PDT), 
Jason Baron <almostivan@yahoo.com> wrote:
>If I enable xconfig, I get these errors from the 
>linux-2.4.19-ia64-020821.diff:
>
>ERROR - Attempting to write value for unconfigured
>variable (CONFIG_BLK_DEV_LOOP).
>ERROR - Attempting to write value for unconfigured
>variable (CONFIG_BLK_DEV_NBD).
>ERROR - Attempting to write value for unconfigured
>variable (CONFIG_BLK_DEV_RAM).
>
>The consequence is that these parameters do not get
>written to the appropriate files.  Also, there are two
>top level "Block devices" menues.
>
>This issue has been discussed a bit and I agree that
>the right solution is probably to fix the way that
>xconfig works.

It is an undocumented restriction of xconfig that an option should only
be set in one menu.  xconfig can detect sets of options within a menu,
it sometimes detects sets of options across menus but do not rely on
that.  Nobody who has looked at the xconfig code is willing to remove
this restriction (they usually turn white and and run away).

Unfortunately some architectures break this rule and break xconfig.

>Short of this, we could choose not to
>source drivers/block/Config.in, and instead include
>the drivers/block/Config.in parameters in
>arch/ia64/config.in, as in the attached patch.  This
>bloats the file a bit, but solves the issue in an arch
>independent way.

Given the current menuconfig and xconfig code, the only workable fix is
to follow the config rules.  That means any variable should only be set
in one menu.  Do not duplicate variables in arch/ia64/config.in.
Instead add conditions around the variables in drivers/block/Config.in
and other Config.in files.

I sent DM a patch to do just this, but he rejected it.  Instead xconfig
was disabled.  Disabling xconfig is not the solution, multiple
definitions of a variable in multiple menus will silently break
menuconfig as well (think out of order menu selection).



      parent reply	other threads:[~2002-08-28 19:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-28 16:02 [Linux-ia64] make xconfig Jason Baron
2002-08-28 16:16 ` Bjorn Helgaas
2002-08-28 16:33 ` Jason Baron
2002-08-28 19:11 ` Keith Owens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590701905997@msgid-missing \
    --to=kaos@ocs.com.au \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox