From: Matthew Wilcox <willy@debian.org>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] Problem with pci_read_config_word_nodev in 2.4.20
Date: Fri, 13 Dec 2002 03:05:33 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590709805558@msgid-missing> (raw)
I'm trying to get the acpiphp driver going on an HP system.
Unfortunately, it crashes the machine on zx1 systems due to uninitialised
sysdata. I'm using the 2.4.20 patch from Bjorn, plus the 0.4 acpiphp
driver that was submitted for 2.4.21.
Here's the problem:
acpiphp_enable_slot()
|-> enable_device()
|-> acpiphp_configure_slot()
|-> pci_read_config_byte_nodev()
|-> build_dev()
|-> pci_read_config_byte(dev)
|-> dev->bus->ops->read_byte()
And the zx1 read_byte operation attempts to dereference a struct which
sysdata points to. But build_dev() doesn't fill in sysdata, and it has
no easy way to get it.
I really don't know the best way to fix this. Part of me says to fix
the _nodev() API to take a struct pci_bus *. Part of me says that's too
big for 2.4 and not necessary for 2.5. So maybe we should stash the sysdata
in the acpiphp_bridge.
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
reply other threads:[~2002-12-13 3:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590709805558@msgid-missing \
--to=willy@debian.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox