From: Xavier Bru <Xavier.Bru@bull.net>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] Can't boot in SMP with kernel 2.5.50 ia64
Date: Thu, 19 Dec 2002 07:53:06 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590709805616@msgid-missing> (raw)
Hello,
Booting 2.5.50 with David's patch, it seems we can't boot in SMP on an
ia64 machine. We get the message: SMP mode deactivated.
Problem is due to smp_prepare_cpus() declaring max_cpus as "unsigned
int" and testing against the -1 value.
Problem was not seen in 2.5.45 because max_cpus was initialized to
UINT_MAX.
Boot in SMP is OK with the following patch:
diff --exclude-from /home/xb/proc/diff.exclude -Nur 2.5.50.ref/arch/ia64/kernel/smpboot.c 2.5.50/arch/ia64/kernel/smpboot.c
--- 2.5.50.ref/arch/ia64/kernel/smpboot.c Wed Dec 18 11:15:48 2002
+++ 2.5.50/arch/ia64/kernel/smpboot.c Wed Dec 18 15:11:52 2002
@@ -472,7 +472,7 @@
* Cycle through the APs sending Wakeup IPIs to boot each.
*/
void __init
-smp_prepare_cpus (unsigned int max_cpus)
+smp_prepare_cpus (int max_cpus)
{
int boot_cpu_id = hard_smp_processor_id();
diff --exclude-from /home/xb/proc/diff.exclude -Nur 2.5.50.ref/include/linux/smp.h 2.5.50/include/linux/smp.h
--- 2.5.50.ref/include/linux/smp.h Wed Dec 18 11:15:48 2002
+++ 2.5.50/include/linux/smp.h Wed Dec 18 15:28:47 2002
@@ -34,7 +34,7 @@
/*
* Prepare machine for booting other CPUs.
*/
-extern void smp_prepare_cpus(unsigned int max_cpus);
+extern void smp_prepare_cpus(int max_cpus);
/*
* Bring a CPU up
--
Sincères salutations.
_____________________________________________________________________
Xavier BRU BULL ISD/R&D/INTEL office: FREC B1-422
tel : +33 (0)4 76 29 77 45 http://www-frec.bull.fr
fax : +33 (0)4 76 29 77 70 mailto:Xavier.Bru@bull.net
addr: BULL, 1 rue de Provence, BP 208, 38432 Echirolles Cedex, FRANCE
_____________________________________________________________________
next reply other threads:[~2002-12-19 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-19 7:53 Xavier Bru [this message]
2002-12-19 20:40 ` [Linux-ia64] Can't boot in SMP with kernel 2.5.50 ia64 David Mosberger
2002-12-20 8:23 ` Xavier Bru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590709805616@msgid-missing \
--to=xavier.bru@bull.net \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox