Re: [Linux-ia64] Can't boot in SMP with kernel 2.5.50 ia64

Xavier Bru
2002-12-20T08:23:00Z

David Mosberger writes:
> >>>>> On Thu, 19 Dec 2002 08:53:06 +0100 (NFT), Xavier Bru <Xavier.Bru@bull.net> said:
>
> Xavier> Hello,
>
> Xavier> Booting 2.5.50 with David's patch, it seems we can't boot in
> Xavier> SMP on an ia64 machine. We get the message: SMP mode
> Xavier> deactivated. Problem is due to smp_prepare_cpus() declaring
> Xavier> max_cpus as "unsigned int" and testing against the -1 value.
> Xavier> Problem was not seen in 2.5.45 because max_cpus was
> Xavier> initialized to UINT_MAX.
>
> I think the test in smp_prepare_cpus() is bogus. I changed it to test
> just against 0 (as is done in the x86 version of smpboot.c).
>
> --david

Hi David,
Thanks for answering my mail.
I just changed to "int" because I saw that max_cpus can be modified at
boot time (maxcpus=...), and get_option() provides an int.
I think this is why test was done against a negative or null value.

"Joyeux Noel et Bonne Annee a tous".

--

Sincères salutations.
_____________________________________________________________________

Xavier BRU BULL ISD/R&D/INTEL office: FREC B1-422
tel : +33 (0)4 76 29 77 45 http://www-frec.bull.fr
fax : +33 (0)4 76 29 77 70 mailto:Xavier.Bru@bull.net
addr: BULL, 1 rue de Provence, BP 208, 38432 Echirolles Cedex, FRANCE
_____________________________________________________________________