From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] [Patch] Fix in process.c
Date: Sat, 18 Jan 2003 01:53:04 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590709805722@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590709805720@msgid-missing>
This one I REALLY don't like:
>>>>> On Fri, 17 Jan 2003 17:43:44 -0800, "Siddha, Suresh B" <suresh.b.siddha@intel.com> said:
Suresh> - extern char ia64_ret_from_clone;
Suresh> + extern void ia64_ret_from_clone(void);
Suresh> - child_stack->b0 = (unsigned long) &ia64_ret_from_clone;
Suresh> + child_stack->b0 = ((unsigned long *) &ia64_ret_from_clone)[0];
Why materialize a function pointer for ABSOLUTELY no reason?
Furthermore, &FUNC can be used as a static initializer, whereas
((long*)&FUNC)[0] cannot.
--david
next prev parent reply other threads:[~2003-01-18 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-18 1:43 [Linux-ia64] [Patch] Fix in process.c Siddha, Suresh B
2003-01-18 1:53 ` David Mosberger [this message]
2003-01-18 3:04 ` Siddha, Suresh B
2003-01-18 3:11 ` David Mosberger
2003-01-18 3:39 ` Siddha, Suresh B
2003-01-21 2:41 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590709805722@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox