public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn_helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] [PATCH] IA32 support without sysctl doesn't work
Date: Thu, 06 Mar 2003 21:55:51 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590709805990@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590709805797@msgid-missing>

> The ia32 subsystem should mirror what's done in kernel/sysctl.c: when
> CONFIG_SYSCTL isn't defined, there should be a dummy sys32_sysctl().
> That way, the number of #ifdefs is localized to one file.

I applied the following patch to 2.4:

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1009.1.5 -> 1.1009.1.6
#	arch/ia64/ia32/sys_ia32.c	1.16    -> 1.16.1.1
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/03/06	bjorn_helgaas@hp.com	1.1009.1.6
# ia64: Make CONFIG_SYSCTL control sys32_sysctl as well.  Based on a
# patch from Peter Chubb.
# --------------------------------------------
#
diff -Nru a/arch/ia64/ia32/sys_ia32.c b/arch/ia64/ia32/sys_ia32.c
--- a/arch/ia64/ia32/sys_ia32.c	Thu Mar  6 14:40:13 2003
+++ b/arch/ia64/ia32/sys_ia32.c	Thu Mar  6 14:40:13 2003
@@ -3407,6 +3407,7 @@
 asmlinkage long
 sys32_sysctl (struct sysctl32 *args)
 {
+#ifdef CONFIG_SYSCTL
 	struct sysctl32 a32;
 	mm_segment_t old_fs = get_fs ();
 	void *oldvalp, *newvalp;
@@ -3444,6 +3445,9 @@
 		return -EFAULT;
 
 	return ret;
+#else
+	return -ENOSYS;
+#endif
 }
 
 asmlinkage long



  parent reply	other threads:[~2003-03-06 21:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-02 22:54 [Linux-ia64] [PATCH] IA32 support without sysctl doesn't work Peter Chubb
2003-02-03 19:34 ` David Mosberger
2003-03-06 21:55 ` Bjorn Helgaas [this message]
2003-03-07  6:28 ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590709805990@msgid-missing \
    --to=bjorn_helgaas@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox