public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] Re: Memory leak in 2.5.64
Date: Wed, 12 Mar 2003 06:53:02 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590709806051@msgid-missing> (raw)

>>>>> On Tue, 11 Mar 2003 14:44:14 +1100, Peter Chubb <peter@chubb.wattle.id.au> said:

  Peter> Hi David, The way that tasks need to be freed has changed
  Peter> since 2.5.61 --- I think we need to do something like the
  Peter> attached patch (keep __put_task_struct() in kernel/fork.c;
  Peter> have ia64-specific free_task_struct() in
  Peter> arch/ia64/kernel/process.c) otherwise the user_struct will
  Peter> never have its reference count deleted and so will not be
  Peter> freed.

Yes, indeed.  The patch basically looks good to me, except it
shouldn't say CONFIG_IA64.  The choice of whether or not thread_info
and task_struct should be allocated in one chunk should be a general
platform-choice.  There really isn't anything ia64-specific about it.

	--david


                 reply	other threads:[~2003-03-12  6:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590709806051@msgid-missing \
    --to=davidm@napali.hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox