From: Andreas Schwab <schwab@suse.de>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] Idenitfier clash in read_[un]lock
Date: Tue, 18 Mar 2003 14:33:42 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590709806152@msgid-missing> (raw)
The read_lock and read_unlock macros should not use such innocent variable
names like tmp because they have a high probability to clash with (part
of) the argument.
Andreas.
--- include/asm-ia64/spinlock.h.~1~ 2002-08-03 02:39:45.000000000 +0200
+++ include/asm-ia64/spinlock.h 2003-03-18 10:10:19.000000000 +0100
@@ -112,7 +112,7 @@ typedef struct {
#define read_lock(rw) \
do { \
- int tmp = 0; \
+ int __read_lock_tmp = 0; \
__asm__ __volatile__ ("1:\tfetchadd4.acq %0 = [%1], 1\n" \
";;\n" \
"tbit.nz p6,p0 = %0, 31\n" \
@@ -127,15 +127,15 @@ do { \
"br.cond.sptk.few 1b\n" \
";;\n" \
".previous\n" \
- : "=&r" (tmp) \
+ : "=&r" (__read_lock_tmp) \
: "r" (rw) : "p6", "memory"); \
} while(0)
#define read_unlock(rw) \
do { \
- int tmp = 0; \
+ int __read_unlock_tmp = 0; \
__asm__ __volatile__ ("fetchadd4.rel %0 = [%1], -1\n" \
- : "=r" (tmp) \
+ : "=r" (__read_unlock_tmp) \
: "r" (rw) \
: "memory"); \
} while(0)
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next reply other threads:[~2003-03-18 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-18 14:33 Andreas Schwab [this message]
2003-03-18 23:00 ` [Linux-ia64] Idenitfier clash in read_[un]lock David Mosberger
2003-03-19 9:53 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590709806152@msgid-missing \
--to=schwab@suse.de \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox