public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Chubb <peter@chubb.wattle.id.au>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] Bug in sba_iommu.c (2.5.64)
Date: Tue, 01 Apr 2003 04:39:21 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590723705373@msgid-missing> (raw)

OK, thanks to some inspired debugging work by Matthew Chapman, we now
have the error.   sba_map_sg() was passing the uninitialised  dma
address from the sg-list to sba_map_single() instead of the virtual
address.  This meant that the dma when it happened scribbled over
random memory causing an MCA later, or possibly caused an MCA immediately.

Patch against 2.5.64 appended.


=== linux-userdrivers/arch/ia64/hp/common/sba_iommu.c 1.10 vs edited ==--- 1.10/arch/ia64/hp/common/sba_iommu.c	Wed Feb  5 12:06:01 2003
+++ edited/arch/ia64/hp/common/sba_iommu.c	Tue Apr  1 14:31:50 2003
@@ -1119,7 +1119,7 @@
 	/* Fast path single entry scatterlists. */
 	if (nents = 1) {
 		sba_sg_iova(sglist) = sba_map_single(dev,
-						     (void *) sba_sg_iova(sglist),
+						     (void *)sba_sg_address(sglist),
 						     sba_sg_len(sglist), direction);
 		sba_sg_iova_len(sglist) = sba_sg_len(sglist);
 #ifdef CONFIG_PROC_FS


                 reply	other threads:[~2003-04-01  4:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590723705373@msgid-missing \
    --to=peter@chubb.wattle.id.au \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox