From: Keith Owens <kaos@ocs.com.au>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] Re: [PATCH] sal calls w/o taking sal_lock
Date: Wed, 02 Apr 2003 06:20:19 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590723705383@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590723705378@msgid-missing>
On Wed, 2 Apr 2003 00:09:53 -0600 ,
"Van Maren, Kevin" <kevin.vanmaren@unisys.com> wrote:
>> I do not understand why you renamed the variables. The SAL code is
>> enclosed in do { } while(); All variables within {} are
>> local, they do not need unique names.
>
>What happens to this:
>
>#define foo(arg) do { int flag; arg = flag; } while (0)
>
>If I do this:
>
> foo(flag);
>
>Answer:
>
> do { int flag; flag = flag; } while (0);
>
>Does his change make more sense now?
You get around that by using __flags in the macro. You do not need
__ia64_sc_flags in SAL_CALL() and a different __ia64_scn_flags in
SAL_CALL_NOLOCK(). The old SAL_CALL() code has been there since IA64
was released and has never had any problems with name scopes.
next prev parent reply other threads:[~2003-04-02 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-01 20:28 [Linux-ia64] Re: [PATCH] sal calls w/o taking sal_lock David Mosberger
2003-04-01 20:32 ` Jesse Barnes
2003-04-02 5:18 ` Keith Owens
2003-04-02 6:09 ` Van Maren, Kevin
2003-04-02 6:20 ` Keith Owens [this message]
2003-04-02 8:55 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590723705383@msgid-missing \
--to=kaos@ocs.com.au \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox