public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] module support for 2.5 kernel
Date: Thu, 03 Apr 2003 20:08:46 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590723705402@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590723705330@msgid-missing>

  Xavier> Hi David,

  Xavier> Thanks for providing this important functionality.

  Xavier> We found the following (minor :-) problems:

  Xavier> 1) missing module.o in arch/ia64/kernel/Makefile.

Oops, I must have dropped that by accident.  Sorry.

  Xavier> 2) using CONFIG_MODVERSIONS, the per-cpu-check.awk script fails with
  Xavier> __crc_xxx symbols:

  Xavier> 000000004d13d7e9 A __crc_page_states__per_cpu not in per-cpu section
  Xavier> 00000000b4f8f003 A __crc_cpu_info__per_cpu not in per-cpu section
  Xavier> make: *** [vmlinux] Error 1

  Xavier> Just changing the script to ignore them fixes the problem.

Yes, the warning is bogus.  Your fix looks fine to me.

  Xavier> 3) with CONFIG_NUMA set, there are undefined symbols building modules:

  Xavier> scripts/modpost vmlinux drivers/md/dm-mod.o drivers/net/e1000/e1000.o drivers/net/eepro100.o drivers/md/md.o drivers/net/mii.o fs/xfs/xfs.o
  Xavier> *** Warning: "cpu_info__per_cpu" [fs/xfs/xfs.ko] undefined!
  Xavier> *** Warning: "cpu_info__per_cpu" [drivers/md/md.ko] undefined!
  Xavier> *** Warning: "cpu_to_node_map" [drivers/md/md.ko] undefined!

  Xavier> exporting them in ia64_ksyms.c fixes the problem.

  Xavier> Hereafter a possible patch that applies on top of yours:

OK, I don't know why cpu_info__per_cpu wasn't exported for NUMA.  I
suspect it had something to do with using node-local memory.  If
someone sees a problem with exporting this symbol, please speak up.

	--david


      parent reply	other threads:[~2003-04-03 20:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-26 20:37 [Linux-ia64] module support for 2.5 kernel David Mosberger
2003-04-03 13:04 ` Xavier Bru
2003-04-03 20:08 ` David Mosberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590723705402@msgid-missing \
    --to=davidm@napali.hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox