public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex_williamson@attbi.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] [PATCH] fix timer interrupts getting lost
Date: Thu, 24 Apr 2003 04:16:43 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590723705596@msgid-missing> (raw)

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]


    This patch fixes the issue of some CPUs not showing timer interrupts
going off.  Seems during the process of sync'ing the itc, we jumped over
the next timer value.  This patch is against 2.5.67 + ia64.  I haven't
seen the problem on 2.4, but a quick looks seems like it's potentially
an issue there too.  Thanks,

	Alex

--
Alex Williamson                             HP Linux and Open Source Lab

[-- Attachment #2: smp_timer_fix.diff --]
[-- Type: text/plain, Size: 523 bytes --]

--- linux-2.5.67.clean/arch/ia64/kernel/smpboot.c	2003-04-22 13:58:09.000000000 -0600
+++ linux-2.5.67/arch/ia64/kernel/smpboot.c	2003-04-23 20:25:00.000000000 -0600
@@ -311,6 +311,15 @@
 		 */
 		Dprintk("Going to syncup ITC with BP.\n");
 		ia64_sync_itc(0);
+
+		/*
+		 * Make sure we didn't sync the itc ahead of the next
+		 * timer interrupt, if so, just reset it.
+		 */
+		if (time_after(ia64_get_itc(),local_cpu_data->itm_next)) {
+			Dprintk("oops, jumped a timer.\n");
+			ia64_cpu_local_tick();
+		}
 	}
 
 	/*

             reply	other threads:[~2003-04-24  4:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-24  4:16 Alex Williamson [this message]
2003-04-24 11:56 ` [Linux-ia64] [PATCH] fix timer interrupts getting lost Takayoshi Kochi
2003-05-06 18:59 ` David Mosberger
2003-05-09 20:44 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590723705596@msgid-missing \
    --to=alex_williamson@attbi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox