public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] janitor patch for _PAGE_SIZE_*
Date: Tue, 06 May 2003 19:34:49 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590723705645@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590723705627@msgid-missing>

>>>>> On Fri, 2 May 2003 15:45:09 +1000, Martin Pool <mbp@samba.org> said:

  Martin> I was looking at the ia64 port and noticed the _PAGE_SIZE*
  Martin> definitions are inconsistent with other uses of this term in
  Martin> the kernel.

  Martin> This patch just renames them to _PAGE_SHIFT.  It only touches ia64
  Martin> code.

I'm not going to apply this one for the following reason: those macros
actually are page-size _codes_ for the PTEs.  Yes, the codes happen to
be equal to the log2() of the page-size, but this isn't necessarily
so.  It's probably unlikely this will ever change, but unless it's
nailed down by the architecture somewhere (I don't think it is), I'd
like to leave that distinction.  Subtle as it may be.

	--david


      reply	other threads:[~2003-05-06 19:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-02  5:45 [Linux-ia64] janitor patch for _PAGE_SIZE_* Martin Pool
2003-05-06 19:34 ` David Mosberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590723705645@msgid-missing \
    --to=davidm@napali.hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox