RE: [Linux-ia64] Re: [PATCH] head.S fix for unusual load addrs

David Mosberger
2003-05-15T03:05:35Z

The patch looks mostly fine to me. I'm not too fond of the __tpa()
and __imva() macros, but that may be mainly a matter of preference.
What I definitely don't like is that the casting seems rather confused
and that the patch is adding __tpa() when we already have ia64_tpa().
As an example of the casting issues: __imva() returns a long, but at
times it's cast to "unsigned long" which doesn't make a lot of sense
(for assignments, anyhow). Moreover, we should stick to the Linux
principle that kernel-space pointers have a type of "void *".

--david