From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Mosberger Date: Wed, 18 Jun 2003 17:42:55 +0000 Subject: Re: [RFC/PATCH] discontig update for linux-ia64-2.5 bk tree Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org Jesse, Jesse> There are a few hunks that remove #ifdef CONFIG_VIRTUAL_MEMMAP lines, Jesse> but maybe that config option should be removed altogether and made the Jesse> default? Why? I want the CONFIG_VIRTUAL_MEMMAP there, because it clearly identifies the code and if we ever have any doubts about its performance effects, we can easily try without virtual mem_map. - default y if IA64_GENERIC || IA64_DIG || IA64_HP_ZX1 + default y if IA64_GENERIC || IA64_DIG || IA64_HP_ZX1 || IA64_SGI_SN2 Looks like this should be changed to: + default y if !IA64_HP_SIM Ditto for the other places. Please declare as "extern": +int filter_rsvd_memory(unsigned long start, unsigned long end, void *arg); THanks, --david