Re: IA-32 support patch: fcntl64 calls are broken

Arun Sharma
2003-06-25T18:18:17Z

Bjorn Helgaas wrote:
> 2.5 has this code, which looks suspicious to me (do we really mean
> to call sys_fcntl() twice?):

Cc'ing the author of this patch in 2.5. Stephen, did you mean to call sys_fcntl() twice ?

-Arun

>
> case F_GETLK64:
> case F_SETLK64:
> case F_SETLKW64:
> ret = get_compat_flock64(&f, compat_ptr(arg));
> if (ret != 0)
> break;
> old_fs = get_fs();
> set_fs(KERNEL_DS);
> ret = sys_fcntl(fd, F_GETLK, (unsigned long)&f);
> ret = sys_fcntl(fd, (cmd = F_GETLK64) ? F_GETLK :
> ((cmd = F_SETLK64) ? F_SETLK : F_SETLKW),
> (unsigned long)&f);
>