From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: IA-32 support patch: fcntl64 calls are broken
Date: Thu, 26 Jun 2003 05:02:57 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105660379711836@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105649509512709@msgid-missing>
On Wednesday 25 June 2003 3:06 pm, I wrote:
> On Tuesday 24 June 2003 4:51 pm, Arun Sharma wrote:
> > Currently, sys32_fcntl64() is broken, because it passes F_*64 commands to sys_fcntl(), which it doesn't understand. The F_XXX64 commands need to be converted to F_XXX before calling sys_fcntl().
>
> As far as I can tell, this is almost equivalent to, but uglier than,
> the mips64 version:
Never mind. Besides being unnecessarily rude, I had obviouisly
forgotten the fragment from 2.5 that I just quoted. Your patch
looks very much like the 2.5 code, which I think is the best
approach. Even though I think the switch is more readable than
the nested ternary expressions, it's better to follow 2.5.
I apologize.
Bjorn
next prev parent reply other threads:[~2003-06-26 5:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-24 22:51 IA-32 support patch: fcntl64 calls are broken Arun Sharma
2003-06-25 16:53 ` Bjorn Helgaas
2003-06-25 18:18 ` Arun Sharma
2003-06-25 21:06 ` Bjorn Helgaas
2003-06-26 1:27 ` Stephen Rothwell
2003-06-26 5:02 ` Bjorn Helgaas [this message]
2003-07-08 18:57 ` Arun Sharma
2003-07-08 19:16 ` Matthew Wilcox
2003-07-08 21:51 ` Arun Sharma
2003-07-15 19:26 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105660379711836@msgid-missing \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox