From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: copy_thread preserves kernel stack
Date: Mon, 07 Jul 2003 21:13:12 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105761241902152@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105719797219701@msgid-missing>
>>>>> On Thu, 03 Jul 2003 12:02:54 +1000, Keith Owens <kaos@ocs.com.au> said:
Keith> ia64 has a comment "Note: if we get called through
Keith> kernel_thread() then the memory above "(highest addr)" is
Keith> valid kernel stack memory that needs to be copied as well".
Keith> i386 kernel threads work fine without the extra stack
Keith> wastage, so there is no generic reason to save the parent
Keith> backtrace. Apart from unwind problems, I can see no reason
Keith> for ia64 to preserve the parent's task in kernel threads.
Keith> Any objections to me doing a patch that constructs an empty
Keith> stack for ia64 kernel threads?
If the patch is clean, I wouldn't have a problem with it. (Please
make sure that the call-chain of the child thread is properly
terminated, so the unwinder knows when to stop.)
(There used to be only few kernel threads, with little risk of kernel
stack overflows, but nowadays (2.5.xx) the situation is quite
different, so it probably makes sense to make this change).
--david
prev parent reply other threads:[~2003-07-07 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-03 2:02 copy_thread preserves kernel stack Keith Owens
2003-07-07 21:13 ` David Mosberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105761241902152@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox