public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] acpi_register_irq()
Date: Fri, 11 Jul 2003 19:02:34 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105795124411277@msgid-missing> (raw)


acpi_madt is marked as __initdata, so an attempt to use
acpi_register_irq() after we discarded init sections would cause us to
dereference a random location.  Everywhere else uses has_8259 anyway.

Index: arch/ia64/kernel/acpi.c
=================================RCS file: /var/cvs/linux-2.5/arch/ia64/kernel/acpi.c,v
retrieving revision 1.11
diff -u -p -r1.11 acpi.c
--- arch/ia64/kernel/acpi.c	2 Jul 2003 22:07:32 -0000	1.11
+++ arch/ia64/kernel/acpi.c	11 Jul 2003 18:58:43 -0000
@@ -720,7 +720,7 @@ acpi_register_irq (u32 gsi, u32 polarity
 {
 	int vector = 0;
 
-	if (acpi_madt->flags.pcat_compat && (gsi < 16))
+	if (has_8259 && (gsi < 16))
 		return isa_irq_to_vector(gsi);
 
 	if (!iosapic_register_intr)

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

                 reply	other threads:[~2003-07-11 19:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105795124411277@msgid-missing \
    --to=willy@debian.org \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox