From: Peter Chubb <peterc@gelato.unsw.edu.au>
To: linux-ia64@vger.kernel.org
Subject: qla1280 bandaid
Date: Tue, 02 Sep 2003 04:57:15 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106247866314538@msgid-missing> (raw)
Hi Jes,
The problem is that bus_reset drops the HOST_LOCK when it calls
schedule_timeout, but when it's called from the initialisation code,
HOST_LOCK isn't actually held.
The appended patch fixes this; however, I'm not sure that it's
correct, because I couldn't work out easily whether the HOST_LOCK is
held or not on all paths to qla1280_bus_reset().
With the patch in place, I can once again boot SMP I2000 and rx4610.
=== drivers/scsi/qla1280.c 1.44 vs edited ==--- 1.44/drivers/scsi/qla1280.c Fri Aug 15 09:08:54 2003
+++ edited/drivers/scsi/qla1280.c Tue Sep 2 14:53:32 2003
@@ -3346,9 +3346,9 @@
ha->bus_settings[bus].scsi_bus_dead = 1;
ha->bus_settings[bus].failed_reset_count++;
} else {
- spin_unlock_irq(HOST_LOCK);
+/* spin_unlock_irq(HOST_LOCK);*/
schedule_timeout(reset_delay * HZ);
- spin_lock_irq(HOST_LOCK);
+/* spin_lock_irq(HOST_LOCK);*/
ha->bus_settings[bus].scsi_bus_dead = 0;
ha->bus_settings[bus].failed_reset_count = 0;
next reply other threads:[~2003-09-02 4:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-02 4:57 Peter Chubb [this message]
2003-09-02 20:18 ` qla1280 bandaid Christoph Hellwig
2003-09-03 16:46 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106247866314538@msgid-missing \
--to=peterc@gelato.unsw.edu.au \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox