From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Date: Wed, 03 Sep 2003 16:46:19 +0000 Subject: Re: qla1280 bandaid Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org >>>>> "Christoph" = Christoph Hellwig writes: Christoph> On Tue, Sep 02, 2003 at 02:57:15PM +1000, Peter Chubb Christoph> wrote: >> Hi Jes, The problem is that bus_reset drops the HOST_LOCK when it >> calls schedule_timeout, but when it's called from the >> initialisation code, HOST_LOCK isn't actually held. >> >> The appended patch fixes this; however, I'm not sure that it's >> correct, because I couldn't work out easily whether the HOST_LOCK >> is held or not on all paths to qla1280_bus_reset(). Christoph> Right fix would probably be to take the lock always before Christoph> calling.. Peter and Christoph, Thanks for the info, I'll take a look at integrating this into the next version. Cheers, Jes