From: "Randy.Dunlap" <rddunlap@osdl.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] disable legacy floppy related ioctl32s
Date: Tue, 30 Sep 2003 21:01:11 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106495655825973@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106495318021597@msgid-missing>
On Tue, 30 Sep 2003 14:55:00 -0600 Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
| On Tuesday 30 September 2003 2:16 pm, Arun Sharma wrote:
| > Since we don't support legacy floppy devices on ia64, this patch disables the corresponding ioctl32.
|
| -#ifndef CONFIG_ARCH_S390
| +#if !defined(CONFIG_ARCH_S390) && !defined(CONFIG_IA64)
| /* 0x02 -- Floppy ioctls */
| COMPATIBLE_IOCTL(FDMSGON)
| COMPATIBLE_IOCTL(FDMSGOFF)
|
| Could this be done with config symbols somehow, i.e., CONFIG_BLK_DEV_FD?
| It seems sort of ugly to encode the knowledge about which platforms
| support legacy floppy both in Kconfig and in the actual source.
|
| BTW, it looks like one can still select legacy floppy support on ia64:
|
| config BLK_DEV_FD
| tristate "Normal floppy disk support"
| depends on !X86_PC9800 && !ARCH_S390
Yes, I submitted a patch for that (and others), but it was rejected
by reasoning that we can't and don't want to keep up with fixing
all of these...
--
~Randy
next prev parent reply other threads:[~2003-09-30 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-30 20:16 [PATCH] disable legacy floppy related ioctl32s Arun Sharma
2003-09-30 20:55 ` Bjorn Helgaas
2003-09-30 21:01 ` Randy.Dunlap [this message]
2003-09-30 22:10 ` Bjorn Helgaas
2003-09-30 22:14 ` Randy.Dunlap
2003-09-30 22:18 ` Arun Sharma
2003-10-01 0:01 ` Arun Sharma
2003-10-01 1:19 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106495655825973@msgid-missing \
--to=rddunlap@osdl.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox