From: Stephane Eranian <eranian@hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] small cleanups + fixes for perfmon.c
Date: Wed, 08 Oct 2003 17:52:38 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106563594518375@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106562332002217@msgid-missing>
John,
On Wed, Oct 08, 2003 at 03:20:02PM +0100, John Levon wrote:
>
> The following patch, compile-tested only so far, does the following :
>
> o removes the [UN]LOCK_BUF_FMT_LIST defines - there is no abstraction
> benefit to them, and they just look ugly
> o fixes two KERN_ERR that should be KERN_INFO
> o removes the "nolock" parameter to the find function (was unused)
> o homogenises the names related to buffer formats
> o removes the hand-crafted list in favour of standard linux list methods
> o reduces code duplication
>
> OK ?
>
Yes, that one looks fine to me. I will apply it
to me version and then submit this to David.
Thanks for the cleanups.
--
-Stephane
prev parent reply other threads:[~2003-10-08 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 14:20 [PATCH] small cleanups + fixes for perfmon.c John Levon
2003-10-08 17:52 ` Stephane Eranian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106563594518375@msgid-missing \
--to=eranian@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox