From: Matthew Wilcox <willy@debian.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Fix IA64 build with separate source and build trees.
Date: Thu, 09 Oct 2003 00:21:48 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106565897210783@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106565735409518@msgid-missing>
On Thu, Oct 09, 2003 at 09:52:12AM +1000, Peter Chubb wrote:
> Hi David,
> This patch against 2.6.0-test7 fixes building in a separate output
> directory. Without it, offsets.h isn't built, and the check-gas and
> toolchain-flags sscripts aren't found.
I'm more curious than anything ...
> +arch/$(ARCH)/kernel/asm-offsets.s: include/asm include/linux/version.h
[...]
> -arch/ia64/kernel/asm-offsets.s: include/asm-ia64/.offsets.h.stamp
> +arch/ia64/kernel/asm-offsets.s: include/asm-$(ARCH)/.offsets.h.stamp
What's the advantage to using $(ARCH) here? Since this is in an arch
directory, we already know our $ARCH. And if we are going to use it,
shouldn't it be used everywhere?
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next prev parent reply other threads:[~2003-10-09 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 23:52 [PATCH] Fix IA64 build with separate source and build trees Peter Chubb
2003-10-09 0:21 ` Matthew Wilcox [this message]
2003-10-09 1:24 ` Peter Chubb
2003-10-09 1:53 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106565897210783@msgid-missing \
--to=willy@debian.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox