From: Andreas Schwab <schwab@suse.de>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] IO{R,W,RW}_BAD
Date: Fri, 10 Oct 2003 08:36:59 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106577527920616@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106572723213144@msgid-missing>
Matthew Wilcox <willy@debian.org> writes:
> We need this patch to compile some drivers. It's a mirror of the patch
> applied to i386 and other architectures.
>
> Index: include/asm-ia64/ioctl.h
> =================================> RCS file: /var/cvs/linux-2.6/include/asm-ia64/ioctl.h,v
> retrieving revision 1.1
> diff -u -p -r1.1 ioctl.h
> --- include/asm-ia64/ioctl.h 29 Jul 2003 17:01:57 -0000 1.1
> +++ include/asm-ia64/ioctl.h 30 Sep 2003 22:23:28 -0000
> @@ -54,11 +54,21 @@
> ((nr) << _IOC_NRSHIFT) | \
> ((size) << _IOC_SIZESHIFT))
>
> +/* provoke compile error for invalid uses of size argument */
> +extern int __invalid_size_argument_for_IOC;
> +#define _IOC_TYPECHECK(t) \
> + ((sizeof(t) = sizeof(t[1]) && \
> + sizeof(t) < (1 << _IOC_SIZEBITS)) ? \
> + sizeof(t) : __invalid_size_argument_for_IOC)
This needs to be implemented differently. Glibc needs to include this
file for <sys/ioctl.h>, but the use of the undefined symbol will make it
impossible to compile without optimisation.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2003-10-10 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-09 19:15 [PATCH] IO{R,W,RW}_BAD Matthew Wilcox
2003-10-10 8:36 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106577527920616@msgid-missing \
--to=schwab@suse.de \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox