On Fri, Oct 10, 2003 at 09:42:35AM -0700, David Mosberger wrote: > I think the source of the probem is that we consider the value > returned by get_offset() to be valid EVEN when read_seqretry() returns > 1. Because of that, we'll end up updating last_nsec_offset with a > potentialy bad value. Well, to my eyes the use of the xtime_lock in do_gettimeofday() looks OK, but I guess what you are saying is that the message is moot -- xtime_lock protects everything itc_get_offset() needs, and do_gettimeofday() has a read lock on xtime_lock and so reads the offset again if something was updated underneath it. -i