public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: important fsyscall bug fix (affects McKinley only)
Date: Wed, 15 Oct 2003 23:58:45 +0000	[thread overview]
Message-ID: <marc-linux-ia64-106626252723372@msgid-missing> (raw)

While working on a lightweight version of sigprocmask(), I discovered
that the McKinley E9 workaround had exactly the opposite effect from
what was intended: it was supposed to ensure that we always return at
priv level 3, and instead it caused us to always return at priv level
0!  Fortunately, the fix is pretty simple and the whole patch can be
found here:

  http://lia64.bkbits.net:8080/linux-ia64-2.5/cset@1.1512.1.22

Since the fsyscall stubs aren't in wide-spread use yet, I doubt this
bug will affect many people, but clearly it would have been a problem
going forward.  Also, remember that the workaround is needed only for
McKinley.  Merced and Madison are both OK in this regard.

The above patch also includes the sigprocmask() light-weight handler
because it's easiest to observe the bug with this handler (since it's
invoked via an inlined syscall; non-inlined syscalls mask the problem,
because they'll return immediately with br.ret again, which drops the
privilege level back to 3).

	--david

                 reply	other threads:[~2003-10-15 23:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-106626252723372@msgid-missing \
    --to=davidm@napali.hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox