From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] fix EFI memory map trimming
Date: Sat, 18 Oct 2003 01:09:50 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106643940222738@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106642910714855@msgid-missing>
>>>>> On Fri, 17 Oct 2003 16:13:44 -0600, Bjorn Helgaas <bjorn.helgaas@hp.com> said:
Bjorn> This fixes a problem in EFI memory map trimming. I've never
Bjorn> been able to wrap my head around the existing code, so this
Bjorn> is perhaps more of a rewrite than it ought to be, but
Bjorn> ... well, you can see what you think.
I think it's a nice improvement and not too much of a rewrite. Just
one small suggestion:
+ if (check_md->attribute & EFI_MEMORY_WB &&
+ check_md->phys_addr = first_non_wb_addr)
This needs a pair of parens to avoid a compiler warning, I think.
--david
next prev parent reply other threads:[~2003-10-18 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-17 22:13 [PATCH] fix EFI memory map trimming Bjorn Helgaas
2003-10-18 1:09 ` David Mosberger [this message]
2003-10-20 15:54 ` Bjorn Helgaas
2003-10-20 18:55 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106643940222738@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox