public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: jbarnes@sgi.com (Jesse Barnes)
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Bug in sn_pci_map_sg causes MCA
Date: Mon, 03 Nov 2003 21:18:55 +0000	[thread overview]
Message-ID: <marc-linux-ia64-106789450614383@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106789192810902@msgid-missing>

On Mon, Nov 03, 2003 at 01:14:00PM -0800, David Mosberger wrote:
> >>>>> On Mon, 3 Nov 2003 12:47:55 -0800, jbarnes@sgi.com (Jesse Barnes) said:
> 
>   Jesse> David, this fixes a critical bug for us.  Can you push it to
>   Jesse> Linus or should we send it straight to Andrew?
> 
> The patch doesn't apply for me, otherwise, I'd have been happy to take
> it (since it's a critical bug fix).  I think it fails to apply because
> TABs got replaced by blanks.

Sorry about that, please try this one.

Jesse

--- /usr/tmp/TmpDir.16109-0/linux/arch/ia64/sn/io/machvec/pci_dma.c_1.5	Mon Nov  3 13:00:46 2003
+++ linux/arch/ia64/sn/io/machvec/pci_dma.c	Mon Nov  3 13:00:27 2003
@@ -279,8 +279,7 @@
 	 * scatterlist.
 	 */
 	for (i = 0; i < nents; i++, sg++) {
-		phys_addr = __pa(sg->dma_address ? sg->dma_address :
-			(unsigned long)page_address(sg->page) + sg->offset);
+		phys_addr = __pa((unsigned long)page_address(sg->page) + sg->offset);
 
 		/*
 		 * Handle the most common case: 64 bit cards.  This

  parent reply	other threads:[~2003-11-03 21:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-03 20:36 [PATCH] Bug in sn_pci_map_sg causes MCA Alan Mayer
2003-11-03 20:47 ` Jesse Barnes
2003-11-03 21:14 ` David Mosberger
2003-11-03 21:18 ` Jesse Barnes [this message]
2003-11-03 22:07 ` Alan Mayer
2003-11-03 22:35 ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-106789450614383@msgid-missing \
    --to=jbarnes@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox