From: Alex Williamson <alex.williamson@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] 2.4.23 fix deadlock in ia64_mca_cmc_int_caller
Date: Mon, 08 Dec 2003 05:30:00 +0000 [thread overview]
Message-ID: <marc-linux-ia64-107086176219239@msgid-missing> (raw)
On Sun, 2003-12-07 at 22:08, Keith Owens wrote:
> smp_call_function() must not be called from interrupt context (can
> deadlock on tasklist_lock). Use keventd to call smp_call_function().
>
Keith,
Looks good to me, only comment I have would be to tack the below
chunk into ia64_mca_late_init(). Anywhere before setting
cmc_polling_enabled to the correct state should prevent a race. Thanks
for fixing this.
Alex
> @@ -2411,3 +2429,12 @@ ia64_mca_disable_cpe_polling(char *str)
> }
>
> __setup("disable_cpe_poll", ia64_mca_disable_cpe_polling);
> +
> +static int __init init_mca(void)
> +{
> + INIT_TQUEUE(&cmc_disable_tq, ia64_mca_cmc_vector_disable_keventd, NULL);
> + INIT_TQUEUE(&cmc_enable_tq, ia64_mca_cmc_vector_enable_keventd, NULL);
> + return 0;
> +}
> +
> +module_init(init_mca)
next reply other threads:[~2003-12-08 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-08 5:30 Alex Williamson [this message]
2003-12-08 6:25 ` [patch] 2.4.23 fix deadlock in ia64_mca_cmc_int_caller Keith Owens
-- strict thread matches above, loose matches on Subject: below --
2003-12-08 5:08 Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-107086176219239@msgid-missing \
--to=alex.williamson@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox