From: Peter Chubb <peter@chubb.wattle.id.au>
To: linux-ia64@vger.kernel.org
Subject: Re: q-tools OOPS: Fixed perfmon.
Date: Tue, 09 Dec 2003 00:17:56 +0000 [thread overview]
Message-ID: <marc-linux-ia64-107092926502909@msgid-missing> (raw)
>>>>> "Stephane" = Stephane Eranian <eranian@hpl.hp.com> writes:
Stephane> I don't think that perfmon-2 support CONFIG_PREEMPT. Try
Stephane> without it.
Here's a fix for non-preemption safety in perfmon.c.
I haven't tried it while running a preemption stress test, but this
allows q-syscollect to work.
=== arch/ia64/kernel/perfmon.c 1.67 vs edited ==--- 1.67/arch/ia64/kernel/perfmon.c Tue Oct 28 17:36:50 2003
+++ edited/arch/ia64/kernel/perfmon.c Tue Dec 9 10:55:58 2003
@@ -5475,7 +5475,7 @@
int this_cpu;
int ret;
- this_cpu = smp_processor_id();
+ this_cpu = get_cpu();
min = pfm_stats[this_cpu].pfm_ovfl_intr_cycles_min;
max = pfm_stats[this_cpu].pfm_ovfl_intr_cycles_max;
next reply other threads:[~2003-12-09 0:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 0:17 Peter Chubb [this message]
2003-12-09 1:24 ` q-tools OOPS: Fixed perfmon Matthew Wilcox
2003-12-09 1:57 ` Stephane Eranian
2003-12-09 3:22 ` David Mosberger
2003-12-09 13:46 ` Martin Hicks
2003-12-09 17:26 ` David Mosberger
2003-12-09 21:54 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-107092926502909@msgid-missing \
--to=peter@chubb.wattle.id.au \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox