From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Latest 2.4 IA64 Baseline (Bjorn) + Latest ACPI testing report
Date: Tue, 16 Dec 2003 16:23:10 +0000 [thread overview]
Message-ID: <marc-linux-ia64-107159183019933@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106863619315583@msgid-missing>
On Tuesday 16 December 2003 5:17 am, Matthew Wilcox wrote:
> On Tue, Dec 16, 2003 at 05:37:35PM +0800, Yu, Luming wrote:
> > Could you let me see what are you patch doing.
>
> I haven't seen Bjorn's patch yet, but it'll be something like:
>
> --- arch/ia64/pci/pci.c 12 Aug 2003 19:10:49 -0000 1.3
> +++ arch/ia64/pci/pci.c 16 Dec 2003 12:13:53 -0000
> @@ -153,7 +153,7 @@ alloc_resource (char *name, struct resou
> res->end = end;
> res->flags = flags;
>
> - if (request_resource(root, res))
> + if (insert_resource(root, res))
> return -EBUSY;
>
> return 0;
Yup, that's exactly the patch.
And I agree with Matthew about preferring this over your patch.
Did you look at /proc/iomem with and without your patch? The
value of keeping the request_resource() (or insert_resource())
should be obvious.
Bjorn
next prev parent reply other threads:[~2003-12-16 16:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-12 11:22 Latest 2.4 IA64 Baseline (Bjorn) + Latest ACPI testing report Yu, Luming
2003-11-19 13:08 ` Yu, Luming
2003-11-20 0:33 ` Bjorn Helgaas
2003-11-20 3:28 ` Matthew Wilcox
2003-11-20 17:09 ` Bjorn Helgaas
2003-11-20 17:29 ` Luck, Tony
2003-12-10 10:29 ` Yu, Luming
2003-12-11 0:34 ` Bjorn Helgaas
2003-12-11 19:32 ` Bjorn Helgaas
2003-12-16 9:37 ` Yu, Luming
2003-12-16 12:17 ` Matthew Wilcox
2003-12-16 16:23 ` Bjorn Helgaas [this message]
2003-12-17 2:54 ` Yu, Luming
2003-12-17 3:07 ` Yu, Luming
2003-12-17 12:23 ` Matthew Wilcox
2003-12-18 2:42 ` Yu, Luming
2003-12-18 12:14 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-107159183019933@msgid-missing \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox