From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] - linux/arch/ia64/kernel/acpi.c
Date: Fri, 19 Dec 2003 23:10:11 +0000 [thread overview]
Message-ID: <marc-linux-ia64-107187556022118@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-107177513519511@msgid-missing>
>>>>> On Thu, 18 Dec 2003 13:14:42 -0600, Jack Steiner <steiner@sgi.com> said:
Jack> The code in acpi_numa_memory_affinity_init that sorts the
Jack> node_memblk can overrun the array & clobber the memory that
Jack> follows the end of the array. The error will be seen only on
Jack> systems that fill the node_memblk array and only if SAL doesnt
Jack> sort the entries in the SRAT.
> --- linux.base/arch/ia64/kernel/acpi.c Wed Nov 26 14:44:07 2003
> +++ linux/arch/ia64/kernel/acpi.c Thu Dec 18 13:10:03 2003
> @@ -413,7 +413,7 @@
> break;
> }
> if (p < pend) {
> - for (q = pend; q >= p; q--)
> + for (q = pend - 1; q >= p; q--)
> *(q + 1) = *q;
> }
> p->start_paddr = paddr;
Looks correct to me. Applied.
--david
prev parent reply other threads:[~2003-12-19 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-18 19:14 [PATCH] - linux/arch/ia64/kernel/acpi.c Jack Steiner
2003-12-19 23:10 ` David Mosberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-107187556022118@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox