From: Jack Steiner <steiner@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] - ia64_ctx.lock deadlock
Date: Sat, 27 Dec 2003 14:27:22 +0000 [thread overview]
Message-ID: <marc-linux-ia64-107253552523782@msgid-missing> (raw)
I hit a deadlock involving the ia64_ctx.lock. The lock
may be taken in interrupt context to process an IPI from smp_flush_tlb_mm.
Here is a patch:
--- linux_base/include/asm-ia64/mmu_context.h Fri Dec 26 11:06:35 2003
+++ linux/include/asm-ia64/mmu_context.h Sat Dec 27 08:19:35 2003
@@ -95,12 +95,13 @@
static inline mm_context_t
get_mmu_context (struct mm_struct *mm)
{
+ unsigned long flags;
mm_context_t context = mm->context;
if (context)
return context;
- spin_lock(&ia64_ctx.lock);
+ spin_lock_irqsave(&ia64_ctx.lock, flags);
{
/* re-check, now that we've got the lock: */
context = mm->context;
@@ -110,7 +111,7 @@
mm->context = context = ia64_ctx.next++;
}
}
- spin_unlock(&ia64_ctx.lock);
+ spin_unlock_irqrestore(&ia64_ctx.lock, flags);
return context;
}
--
Thanks
Jack Steiner (steiner@sgi.com) 651-683-5302
Principal Engineer SGI - Silicon Graphics, Inc.
next reply other threads:[~2003-12-27 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-27 14:27 Jack Steiner [this message]
2003-12-29 20:23 ` [PATCH] - ia64_ctx.lock deadlock David Mosberger
2003-12-29 22:31 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-107253552523782@msgid-missing \
--to=steiner@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox