From: Jes Sorensen <jes@trained-monkey.org>
To: John Keller <jpk@sgi.com>
Cc: linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] RESEND - SN: Add initial ACPI support
Date: Mon, 16 Jan 2006 08:21:01 +0000 [thread overview]
Message-ID: <yq01wz8vb0y.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <20060115182308.22089.1201.sendpatchset@attica.americas.sgi.com>
>>>>> "John" = John Keller <jpk@sgi.com> writes:
John> Please disregard the earlier (01/14) post of this patch. I
John> erroneously sent out an early version, which was not fully
John> merged with the latest ia64 git tree.
Hi John,
Looks much better. On top of Prarit's comments I just noticed this
one:
+ if (!hubdev->hdi_flush_nasid_list.widget_p)
+ return;
+
+ hubdev->hdi_flush_nasid_list.widget_p + kzalloc((HUB_WIDGET_ID_MAX + 1) *
+ sizeof(struct sn_flush_device_kernel *),
+ GFP_KERNEL);
This doesn't look right, if widget_p is NULL no alloc ortherwise
overwrite it? Did the order get reversed?
Cheers,
Jes
next prev parent reply other threads:[~2006-01-16 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-15 18:23 [PATCH] RESEND - SN: Add initial ACPI support John Keller
2006-01-15 20:41 ` Prarit Bhargava
2006-01-16 8:21 ` Jes Sorensen [this message]
2006-01-23 16:00 ` John Keller
2006-01-26 17:20 ` Bjorn Helgaas
2006-01-26 23:04 ` John Keller
2006-01-27 13:54 ` John Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq01wz8vb0y.fsf@jaguar.mkp.net \
--to=jes@trained-monkey.org \
--cc=jpk@sgi.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox