Re: [PATCH] Add support for type argument in PAL_GET_PSTATE

Jes Sorensen
2006-12-01T16:36:19Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1252", Size: 985 bytes --]

>>>>> "Venkatesh" = Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> writes:

Venkatesh> PAL_GET_PSTATE accepts a type argument to return different
Venkatesh> kinds of frequency information. Refer: Intel
Venkatesh> Itanium®Architecture Software Developer's Manual -
Venkatesh> Volume 2: System Architecture, Revision 2.2
Venkatesh> (http://developer.intel.com/design/itanium/manuals/245318.htm)

....

Venkatesh> @@ -79,6 +79,11 @@
Venkatesh> #define PAL_GET_PSTATE 262 /* get the current P-state */
Venkatesh> #define PAL_SET_PSTATE 263 /* set the P-state */
Venkatesh>
Venkatesh> +#define PAL_GET_PSTATE_TYPE_LASTSET (0)
Venkatesh> +#define PAL_GET_PSTATE_TYPE_AVGANDRESET (1)
Venkatesh> +#define PAL_GET_PSTATE_TYPE_AVGNORESET (2)
Venkatesh> +#define PAL_GET_PSTATE_TYPE_INSTANT (3)
Venkatesh> +

Hi Venkatesh,

Please respect the previous formatting of the file and not add
pointless parenthesises around the constants like that.

Cheers,
Jes