public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@trained-monkey.org>
To: Keith Owens <kaos-sJ/iWh9BUns@public.gmane.org>
Cc: John Keller <jpk-sJ/iWh9BUns@public.gmane.org>,
	linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] SN: Add initial ACPI support
Date: Sun, 15 Jan 2006 12:34:54 +0000	[thread overview]
Message-ID: <yq0slrp1xg1.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <28961.1137282162-1LO6/iIh+iQ0n/F98K4Iww@public.gmane.org>

>>>>> "Keith" = Keith Owens <kaos@sgi.com> writes:

Hi,

Just a general comment on top of Keith's.

Keith> John Keller (on Sat, 14 Jan 2006 11:37:47 -0600 (CST)) wrote:
>> +inline uint64_t +sal_ioif_init(void)

Keith> Make that static with no inline, let gcc decide if it should be
Keith> inlined or not.

Please stick to using the preferred kernel internal types, u64/u32/u16
etc. I noticed you switch u64 to uint64_t in many places which is the
wrong way to go.

Regards,
Jes

  parent reply	other threads:[~2006-01-15 12:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-14 17:37 [PATCH] SN: Add initial ACPI support John Keller
     [not found] ` <20060114173747.12715.63396.sendpatchset-iV7pWHqs0A8TG1waqwXmH7Cf4lofQVJ7@public.gmane.org>
2006-01-14 23:42   ` Keith Owens
     [not found]     ` <28961.1137282162-1LO6/iIh+iQ0n/F98K4Iww@public.gmane.org>
2006-01-15 12:34       ` Jes Sorensen [this message]
2006-01-15 17:43         ` John Keller
2006-01-15 16:45       ` John Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq0slrp1xg1.fsf@jaguar.mkp.net \
    --to=jes@trained-monkey.org \
    --cc=jpk-sJ/iWh9BUns@public.gmane.org \
    --cc=kaos-sJ/iWh9BUns@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox