Re: [PATCH/RFC] Port of pdc202xx_new driver to libata

["Albert Lee" <albertcc@tw.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

Jeff:

  Attached please find the patch, thanks.

Albert

Signed-off-by: Albert Lee<albertcc@tw.ibm.com>

----- Original Message ----- 
From: "Jeff Garzik" <jgarzik@pobox.com>
To: "Albert Lee" <albertcc@tw.ibm.com>
Cc: "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>; "IDE Linux"
<linux-ide@vger.kernel.org>
Sent: Friday, October 22, 2004 7:10 AM
Subject: Re: [PATCH/RFC] Port of pdc202xx_new driver to libata


> Albert Lee wrote:
> > Hi, Jeff:
> >
> >  Please see my reply below.
> > I'll resend the patch according to your review/comments later.
> > Thanks for your patience for newbie like me. :-)
>
> Note that I applied your patch... so please just send a follow-up patch,
> diff'd against the latest libata-dev patch/BK.
>
> http://marc.theaimsgroup.com/?t=109782787200002&r=1&w=2&n=4
>
> Jeff
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[-- Attachment #2: pdc2027x-2.diff --]
[-- Type: application/octet-stream, Size: 3453 bytes --]

diff -Nru libata-pdc2-2.6/drivers/scsi/pata_pdc2027x.c libata-pdc2-2.6-mod/drivers/scsi/pata_pdc2027x.c
--- libata-pdc2-2.6/drivers/scsi/pata_pdc2027x.c	2004-10-21 17:17:40.000000000 +0800
+++ libata-pdc2-2.6-mod/drivers/scsi/pata_pdc2027x.c	2004-10-21 17:28:06.990919600 +0800
@@ -29,10 +29,8 @@
 #include <asm/io.h>
 
 #define DRV_NAME	"pata_pdc2027x"
-#define DRV_VERSION	"0.52"
+#define DRV_VERSION	"0.53"
 #undef PDC_DEBUG
-#undef PDC_20276_QUIRK
-#undef PDC_20270_QUIRK
 
 #ifdef PDC_DEBUG
 #define PDPRINTK(fmt, args...) printk(KERN_DEBUG "%s: " fmt, __FUNCTION__, ## args)
@@ -59,7 +57,7 @@
  * These tables are only used when the controller is in 133MHz clock.
  * If the controller is in 100MHz clock, the ASIC hardware will 
  * set the timing registers automatically when "set feature" command 
- * issued to the device. However, if the controller clock is 133MHz, 
+ * is issued to the device. However, if the controller clock is 133MHz, 
  * the following tables must be used.
  */
 static struct pdc2027x_pio_timing {
@@ -554,16 +552,6 @@
 {
 	long pll_clock;
 
-	/* Enable the ROM */
-	/*
-	if (pdev->resource[PCI_ROM_RESOURCE].start) {
-		pci_write_config_dword(pdev, PCI_ROM_ADDRESS,
-			pdev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
-		printk(KERN_INFO DRV_NAME ": ROM enabled at 0x%08lx\n",
-		       pdev->resource[PCI_ROM_RESOURCE].start);
-	}
-	*/
-
 	/*
 	 * Detect PLL input clock rate.
 	 * On some system, where PCI bus is running at non-standard clock rate.
@@ -604,58 +592,6 @@
 	if (!printed_version++)
 		printk(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n");
 
-#ifdef PDC_20276_QUIRK
-	/*
-	 * Skip Promise PDC20276 attached to I2O RAID controller 
-	 */
-	if ((pdev->device == PCI_DEVICE_ID_PROMISE_20276) &&
-	    (pdev->bus->self) &&
-	    (pdev->bus->self->vendor == PCI_VENDOR_ID_INTEL) &&
-	    ((pdev->bus->self->device == PCI_DEVICE_ID_INTEL_I960) ||
-	     (pdev->bus->self->device == PCI_DEVICE_ID_INTEL_I960RM))) {
-		printk(KERN_INFO DRV_NAME ": Skipping Promise PDC20276 "
-		       "attached to I2O RAID controller.\n");
-		return -ENODEV;
-	}
-#endif
-
-#ifdef PDC_20270_QUIRK
-	/*
-	 * Special IRQ handling for Promise PDC20270 attached to the 
-	 * DEC DC21150 PCI south bridge.  (DC21150 PCI bridge can be found 
-	 * on Compaq ProLiant 800 and ProLiant 1600 servers.) 
-	 * FIXME: Not tested yet on libata.
-	 */
-	if ((pdev->device == PCI_DEVICE_ID_PROMISE_20270) &&
-	    (pdev->bus->self) &&
-	    (pdev->bus->self->vendor == PCI_VENDOR_ID_DEC) &&
-	    (pdev->bus->self->device == PCI_DEVICE_ID_DEC_21150)) {
-		struct pci_dev *findev = NULL;
-
-		if (PCI_SLOT(pdev->devfn) & 2) {
-			/* This pdc20270 is in PCI slot with bit 1 set.
-			 * Find the other pdc20270 in PCI slot with bit 1 cleared.
-			 * If found, override my IRQ setting to irq of that device.
-			 */
-			//d->extra = 0; // No extra DMA address on pdc20270
-					   
-			while ((findev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, findev)) != NULL) {
-				if ((findev->vendor == pdev->vendor) &&
-				    (findev->device == pdev->device) &&
-				    (!(PCI_SLOT(findev->devfn) & 2))) {
-					
-					if (pdev->irq != findev->irq) {
-						// Override the IRQ setting
-						pdev->irq = findev->irq;
-						break;
-					}
-				}
-			}
-		}
-
-	}
-#endif
-
 	rc = pci_enable_device(pdev);
 	if (rc)
 		return rc;