From: Damien Le Moal <dlemoal@kernel.org>
To: nikita.shubin@maquefel.me, Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ata: pata_ep93xx: fix error return code in probe
Date: Thu, 24 Aug 2023 08:07:24 +0900 [thread overview]
Message-ID: <00462bc7-43ee-784a-3296-8051d69575df@kernel.org> (raw)
In-Reply-To: <20230823-ep93xx_pata_fixes-v1-1-d7e7229be148@maquefel.me>
On 8/23/23 18:47, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <nikita.shubin@maquefel.me>
>
> Return -ENOMEM from ep93xx_pata_probe() if devm_kzalloc() or
> ata_host_alloc() fails.
>
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Doesn't this need a Fixes tag and Cc: stable ?
This is not really a bug fix, but might as well be complete with the fix :)
> ---
> drivers/ata/pata_ep93xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
> index c6e043e05d43..4ce0f37c7a89 100644
> --- a/drivers/ata/pata_ep93xx.c
> +++ b/drivers/ata/pata_ep93xx.c
> @@ -939,7 +939,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev)
>
> drv_data = devm_kzalloc(&pdev->dev, sizeof(*drv_data), GFP_KERNEL);
> if (!drv_data) {
> - err = -ENXIO;
> + err = -ENOMEM;
> goto err_rel_gpio;
> }
>
> @@ -952,7 +952,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev)
> /* allocate host */
> host = ata_host_alloc(&pdev->dev, 1);
> if (!host) {
> - err = -ENXIO;
> + err = -ENOMEM;
> goto err_rel_dma;
> }
>
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-08-23 23:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 9:47 [PATCH 0/2] ata: pata_ep93xx: dt convert preparation fixes Nikita Shubin via B4 Relay
2023-08-23 9:47 ` [PATCH 1/2] ata: pata_ep93xx: fix error return code in probe Nikita Shubin via B4 Relay
2023-08-23 15:05 ` Sergey Shtylyov
2023-08-23 23:07 ` Damien Le Moal [this message]
2023-08-25 8:05 ` Nikita Shubin
2023-08-25 8:10 ` Damien Le Moal
2023-08-23 9:47 ` [PATCH 2/2] ata: pata_ep93xx: use soc_device_match for UDMA modes Nikita Shubin via B4 Relay
2023-08-23 15:19 ` Sergey Shtylyov
2023-08-25 13:15 ` [PATCH 0/2] ata: pata_ep93xx: dt convert preparation fixes Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00462bc7-43ee-784a-3296-8051d69575df@kernel.org \
--to=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox