From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time Date: Tue, 12 Jul 2016 14:04:32 +0300 Message-ID: <034d8edb-439e-eafe-0743-4b69bf50b49e@cogentembedded.com> References: <1468321179-7647-1-git-send-email-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1468321179-7647-1-git-send-email-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin King , "David S . Miller" , linux-ide@vger.kernel.org Cc: linux-kernel@vger.kernel.org List-Id: linux-ide@vger.kernel.org On 7/12/2016 1:59 PM, Colin King wrote: > From: Colin Ian King > > According to the HPT366 data sheet, PCI config space dword 0x40-0x43 > bits 11:8 specify the primary drive cmd_high_time, however, > currently just 3 bits of the 4 are being used because the mask > is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock > to be detected. > > Also add in missing space between switch and parenthesis to clean > up a checkpatch warning. > > Signed-off-by: Colin Ian King Acked-by: Sergei Shtylyov MBR, Sergei