From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94656C7EE24 for ; Mon, 5 Jun 2023 07:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbjFEH6u (ORCPT ); Mon, 5 Jun 2023 03:58:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231264AbjFEH5o (ORCPT ); Mon, 5 Jun 2023 03:57:44 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9375CE9; Mon, 5 Jun 2023 00:57:43 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4F31C1F8AE; Mon, 5 Jun 2023 07:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685951862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUjOizhKCNd6heWb4WYl0+3v2X+4u56JrhHKxKoYCwM=; b=K//Hra4XSYynswkPe4sEsR0fO0A5YgUz5F+qRrk0Od0GI+qF8JCfpErYLzFYI7oC1xqopO iBQ9L8m3uxXyHYM+2K6Iu+gk57k0U29oSRUSYRbfmZLHkRq3Q+Lr6C+sh8tdutyCvKPJ80 pdNuykSwYNK4CnHiXSvLEHS9RIOg3NA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685951862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUjOizhKCNd6heWb4WYl0+3v2X+4u56JrhHKxKoYCwM=; b=q++AcGdhlZYlMzQkksrnHEapl6oQvble/b/zQ/fRYOLayjApnAnfMqagurGSchF3zvMCct +/DBlxiVhXqfVxBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E0065139C8; Mon, 5 Jun 2023 07:57:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JjrjMXWVfWRAegAAMHmgww (envelope-from ); Mon, 05 Jun 2023 07:57:41 +0000 Message-ID: <07da13b1-e7bd-53b2-29d8-e236c17beb62@suse.de> Date: Mon, 5 Jun 2023 09:57:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/3] ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down() Content-Language: en-US To: Damien Le Moal , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, "Martin K . Petersen" Cc: John Garry , Jason Yan References: <20230605013212.573489-1-dlemoal@kernel.org> <20230605013212.573489-3-dlemoal@kernel.org> From: Hannes Reinecke In-Reply-To: <20230605013212.573489-3-dlemoal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 6/5/23 03:32, Damien Le Moal wrote: > Instead of hardconfign the device flag tests to detect if NCQ is > supported and enabled in ata_eh_speed_down(), use ata_ncq_enabled(). > > Signed-off-by: Damien Le Moal > --- > drivers/ata/libata-eh.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman