From: Damien Le Moal <dlemoal@kernel.org>
To: John Garry <john.g.garry@oracle.com>, linux-ide@vger.kernel.org
Cc: Jason Yan <yanaijie@huawei.com>, Xingui Yang <yangxingui@huawei.com>
Subject: Re: [PATCH v3] ata: libata-scsi: Use correct device no in ata_find_dev()
Date: Tue, 23 May 2023 17:43:25 +0900 [thread overview]
Message-ID: <09265e29-6d89-2876-dbbf-09344536ef8b@kernel.org> (raw)
In-Reply-To: <1da247a6-57d3-a2dc-7375-e5a1fb02f9c1@oracle.com>
On 5/23/23 17:29, John Garry wrote:
[...]
>> + * or 2 (IDE master + slave). However, the former case includes
>> + * libsas hosted devices which are numbered per host, leading
>> + * to devno potentially being larger than 0 but with each ata device
>> + * having its own ata port and ata link. To accommodate these, ignore
>> + * devno and always use device number 0.
>> + */
>> + if (likely(!sata_pmp_attached(ap))) {
>
> Is this function ever used in fastpath? I doubt it, but I suppose having
> likely() can't do any damage.
Yes, we could drop that.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-05-23 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 8:04 [PATCH v3] ata: libata-scsi: Use correct device no in ata_find_dev() Damien Le Moal
2023-05-23 8:29 ` John Garry
2023-05-23 8:43 ` Damien Le Moal [this message]
2023-05-23 9:23 ` Jason Yan
2023-05-23 10:22 ` Damien Le Moal
2023-05-29 6:45 ` Damien Le Moal
2023-05-29 9:10 ` Jason Yan
2023-05-23 9:01 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09265e29-6d89-2876-dbbf-09344536ef8b@kernel.org \
--to=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=yanaijie@huawei.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox