linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 2.6.14-rc2] siimage: enable interrupts on Adaptec SA-1210 card
@ 2005-09-28 21:50 John W. Linville
  2005-11-09 23:17 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2005-09-28 21:50 UTC (permalink / raw)
  To: linux-kernel, linux-ide; +Cc: B.Zolnierkiewicz

The siimage driver proports to support the Adaptec SA-1210 SATA
controller. However, at least some of those cards boot-up with their
interrupts disabled internally. The siimage driver currently ignores
that fact, so that driver does not actually work with those cards. This
patch enables those interrupts on cards that need it.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
This is implemented based on similar code in the libata-based sata_sil
driver.

 drivers/ide/pci/siimage.c |    9 +++++++++
 1 files changed, 9 insertions(+)

diff --git a/drivers/ide/pci/siimage.c b/drivers/ide/pci/siimage.c
--- a/drivers/ide/pci/siimage.c
+++ b/drivers/ide/pci/siimage.c
@@ -701,6 +701,7 @@ static unsigned int setup_mmio_siimage (
 	unsigned long barsize	= pci_resource_len(dev, 5);
 	u8 tmpbyte	= 0;
 	void __iomem *ioaddr;
+	u32 tmp, irq_mask;
 
 	/*
 	 *	Drop back to PIO if we can't map the mmio. Some
@@ -726,6 +727,14 @@ static unsigned int setup_mmio_siimage (
 	pci_set_drvdata(dev, (void *) ioaddr);
 
 	if (pdev_is_sata(dev)) {
+		/* make sure IDE0/1 interrupts are not masked */
+		irq_mask = (1 << 22) | (1 << 23);
+		tmp = readl(ioaddr + 0x48);
+		if (tmp & irq_mask) {
+			tmp &= ~irq_mask;
+			writel(tmp, ioaddr + 0x48);
+			readl(ioaddr + 0x48); /* flush */
+		}
 		writel(0, ioaddr + 0x148);
 		writel(0, ioaddr + 0x1C8);
 	}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 2.6.14-rc2] siimage: enable interrupts on Adaptec SA-1210 card
  2005-09-28 21:50 [patch 2.6.14-rc2] siimage: enable interrupts on Adaptec SA-1210 card John W. Linville
@ 2005-11-09 23:17 ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-11-09 23:17 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-kernel, linux-ide

applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-11-09 23:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-28 21:50 [patch 2.6.14-rc2] siimage: enable interrupts on Adaptec SA-1210 card John W. Linville
2005-11-09 23:17 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).