From: Damien Le Moal <dlemoal@kernel.org>
To: Rosen Penev <rosenp@gmail.com>, linux-ide@vger.kernel.org
Cc: Niklas Cassel <cassel@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b"
<llvm@lists.linux.dev>
Subject: Re: [PATCH] ata: pata_rb532_cf: use devm_platform_ioremap_resource()
Date: Sat, 18 Jul 2026 12:02:18 +0900 [thread overview]
Message-ID: <0dec403f-2c88-4197-b25f-5b112f418e41@kernel.org> (raw)
In-Reply-To: <20260713232143.1114497-1-rosenp@gmail.com>
On 7/14/26 08:21, Rosen Penev wrote:
> Replace the open-coded platform_get_resource() plus devm_ioremap()
> sequence with a single devm_platform_ioremap_resource() call, which folds
> the resource lookup and mapping into one step and returns an ERR_PTR on
> failure, checked with IS_ERR() and propagated via PTR_ERR(). Similar to
> platform_get_irq(), it can return -EPROBE_DEFER so move it early.
>
> The pata-rb532-cf platform device (arch/mips/rb532/devices.c) provides a
> single IORESOURCE_MEM window at the DEV1BASE chip-select, distinct from
> the other RB532 chip-selects, so the region reservation now performed by
> devm_platform_ioremap_resource() introduces no conflict. The mapped size
> is unchanged. Drop the redundant error message, as
> devm_platform_ioremap_resource() already logs on failure.
>
> Built for MIPS (rb532_defconfig) with LLVM=1;
> drivers/ata/pata_rb532_cf.o compiles cleanly.
>
> Assisted-by: opencode:hy3-free
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied to for-7.3. Thanks!
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2026-07-18 3:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 23:21 [PATCH] ata: pata_rb532_cf: use devm_platform_ioremap_resource() Rosen Penev
2026-07-18 3:02 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dec403f-2c88-4197-b25f-5b112f418e41@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox