From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6FCC433FE for ; Fri, 14 Oct 2022 09:47:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbiJNJra (ORCPT ); Fri, 14 Oct 2022 05:47:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbiJNJr3 (ORCPT ); Fri, 14 Oct 2022 05:47:29 -0400 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 042B62CC90 for ; Fri, 14 Oct 2022 02:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1665740847; x=1697276847; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=iE5GUnFyeMBRQvMjHEXX2zn/Gp9BkuhhaBK9MtXM00k=; b=cOol1JbkLAx4B6PVxXbfb4hfVg3BdqzYqLfvFPOLhxURE6NMtUi/Zpm+ hdFXUoyGa0PrahMCkpMv04PJdte/gJpUsuqntYgZ1B093VacxInOt7Myt 6Bbwu9rh0lHJaWJAgRmmJ8uIXFPtZuVkMS1PFb0JWmoGpwKDSN+16LIfX OFliR44+SLi+HP8hWlYuUo2Vblk3n9zKaTh6i0DOamgyA4dXlvhA9zNCg Uykw7nofS+WO/idbT3IIfPoRTtydwHQQP84XK7TUrqcDHijdOvIWX3UVi takjlS5c6RxmqIcgeDWC/VpHzyb8ffRv0i3Zy0D+WaIpbSI9p6XttXlJY A==; X-IronPort-AV: E=Sophos;i="5.95,184,1661788800"; d="scan'208";a="213797166" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 14 Oct 2022 17:47:27 +0800 IronPort-SDR: OSHJ7ZsyZ13GhoWLqmkIHH0Aweew9jk3u71qYvlUoIbQBfBxn2mo7F572I1dVzTrk0vW0gBCCs /yvG1iRT0zMwdIw1Ba7JTHKv6Pwmnr3R2kJZyZV2VCbpZgUmxNnGfPkzdfCoP8cHjQtNVZVBja aQ+8hLCR2UkPKlS+D9lBwsplhNcOoxUle2usS2O8CWdKwZdZT4d1DrO6pGH2n3PrvVekV3n/Wp KdJOg3gi17A4r0nzzTlrjBsAsuLtEa6UbAizGNC1zTwpzYvsGZjUhp75lGO49mOai7ymBXO6xF kZnMIfWUwWbQRuxmElnC1+rQ Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Oct 2022 02:01:25 -0700 IronPort-SDR: O9u+9Sf0U34QooJifQzfCOGFg4eWLOJV0cItpNaB7if4y2Zubtjy69tUifyn7OW3jjL+EklcGd 4m250oxqcxy1PYWy2pKPvlZPjRSXScMNS9SoXO8p+i0/RtBaHvVZ5UeaLDJlcOqldyJQm2PVTD NplemFCav3648PKuKJVpCyvYSzE0Z9LV0r+ywzwYpb/WfeVwkHdkGLbiBV9NiMc1fBs3/mT60b nbSOzg0KCbEm5Z60AliVMQSooFY/HQHkswk2FUpd0hu784vj2r0IQi8gisY97Q4uImbNdiKnXd Iwo= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Oct 2022 02:47:27 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4MphPp6M2yz1RwqL for ; Fri, 14 Oct 2022 02:47:26 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1665740846; x=1668332847; bh=iE5GUnFyeMBRQvMjHEXX2zn/Gp9BkuhhaBK 9MtXM00k=; b=PtF2czCRF+dp0VRC6dLZ04V+8DkQ37SQBwZgiOI+H7Mix1GMkT9 VPCsMXk2iDSfJkaeAhOOX3tXSwusMe5xZ9/nR7wGPHH3odYNCyqhy6lyB7x1ycJU FYfsDRnvlvdXSUQrc5Elbx/BL5Ak8q/x7m2HPQHFepDlXHMb7Vn4RVzXTa7e/7zt GK75GQRzAEUcJj6u8+RmwEkOnIqwf9gKV6pzRR3snzBlDEXH0efib4qSHDt0dN1i XzwlvrRAZCVMI/9zh+BfjtoqIGEiZWDgTax8hmZHS+IGzNPskp8Z5INSEbPxFSm+ VXuJjsOSVTodq5+7zM/ZoxRK2f/pXRmSE3A== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vFaatoAOHuMj for ; Fri, 14 Oct 2022 02:47:26 -0700 (PDT) Received: from [10.225.163.119] (unknown [10.225.163.119]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4MphPm4nqjz1RvLy; Fri, 14 Oct 2022 02:47:24 -0700 (PDT) Message-ID: <0ea781f8-6911-2850-16a2-cee230dd32b0@opensource.wdc.com> Date: Fri, 14 Oct 2022 18:47:23 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag Content-Language: en-US To: Arnd Bergmann , Anders Roxell Cc: Naresh Kamboju , Serge Semin , open list , Linux ARM , regressions@lists.linux.dev, "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , lkft-triage@lists.linaro.org, Lukas Bulwahn , Niklas Cassel References: <7ee4a1bd-0674-42d8-8980-8b029ca09e71@app.fastmail.com> <75eaeab3-7781-d60a-ae61-ae837f5dcec9@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 10/14/22 18:37, Arnd Bergmann wrote: > On Fri, Oct 14, 2022, at 11:22 AM, Anders Roxell wrote: >> On Fri, 14 Oct 2022 at 09:53, Damien Le Moal > >> Tested this patch on todays linux-next tag: next-20221014 without enabling >> CONFIG_AHCI_DWC and it worked as expected when booting [1]. >> On the other hand I also tried a build/boot with CONFIG_AHCI_DWC enabled >> and it worked as expected to boot [2]. That is great news ! So the new driver is OK, good ! > > Ok, great. Can you a patch to soc@kernel.org to enable the driver in the > relevant defconfigs? > >> However, during building a warning [3] popped up: >> >> make --silent --keep-going --jobs=8 >> O=/home/tuxbuild/.cache/tuxmake/builds/2/build ARCH=arm >> CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache >> arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc' >> /builds/linux/drivers/ata/ahci_dwc.c:462:34: warning: 'ahci_dwc_plat' >> defined but not used [-Wunused-variable] >> 462 | static struct ahci_dwc_plat_data ahci_dwc_plat = { > > Strange, I can't reproduce this, and the ahci_dwc_plat symbol > looks like it is clearly used in ahci_dwc_of_match[], at least > in next-20221014. Do you also see this on mainline? This is with the trial fix diff I sent. My bad, it was not even compile tested :). Does not happen otherwise. > Arnd Thanks for helping with this ! -- Damien Le Moal Western Digital Research